Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide "suggestedFilename" in "WebDriver BiDi download started" hook #11139

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

sadym-chromium
Copy link
Contributor

@sadym-chromium sadym-chromium commented Mar 17, 2025

Provide "suggestedFilename" in "WebDriver BiDi download started" hook. Addressing w3c/webdriver-bidi#840.

(See WHATWG Working Mode: Changes for more details.)

@sadym-chromium sadym-chromium changed the title [WIP] Provide "suggestedFilename" in "WebDriver BiDi download started" hook Provide "suggestedFilename" in "WebDriver BiDi download started" hook Mar 25, 2025
@sadym-chromium sadym-chromium marked this pull request as ready for review March 25, 2025 10:42
@sadym-chromium
Copy link
Contributor Author

@domenic could you please take a look?

Copy link
Contributor

@Lightning00Blade Lightning00Blade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also took a look at it and looks good to me.

@domenic
Copy link
Member

domenic commented Mar 26, 2025

Can you ensure the build is passing first?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants